[PATCH] s390: segment operation error codes

Print a warning with the z/VM error code if segment_load, segment_type or
segment_save fail to ease the problem determination.

Signed-off-by: Gerald Schaefer <geraldsc@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/arch/s390/mm/extmem.c b/arch/s390/mm/extmem.c
index a9566bcab682b4bcb2bd83b565ae4aecbd07b830..9b11e3e20903f0305916fcd6e6037a71cefdf43f 100644 (file)
--- a/arch/s390/mm/extmem.c
+++ b/arch/s390/mm/extmem.c
@@ -192,6 +192,7 @@ query_segment_type (struct dcss_segment *seg)
        diag_cc = dcss_diag (DCSS_SEGEXT, qin, &dummy, &vmrc);
 
        if (diag_cc > 1) {
        diag_cc = dcss_diag (DCSS_SEGEXT, qin, &dummy, &vmrc);
 
        if (diag_cc > 1) {

+               PRINT_WARN ("segment_type: diag returned error %ld\n", vmrc);

                rc = dcss_diag_translate_rc (vmrc);
                goto out_free;
        }
                rc = dcss_diag_translate_rc (vmrc);
                goto out_free;
        }


@@ -553,7 +554,7 @@ segment_save(char *name)
        int endpfn = 0;
        char cmd1[160];
        char cmd2[80];
        int endpfn = 0;
        char cmd1[160];
        char cmd2[80];

-       int i;
+       int i, response;

 
        if (!MACHINE_IS_VM)
                return;
 
        if (!MACHINE_IS_VM)
                return;


@@ -576,8 +577,20 @@ segment_save(char *name)
                        segtype_string[seg->range[i].start & 0xff]);
        }
        sprintf(cmd2, "SAVESEG %s", name);
                        segtype_string[seg->range[i].start & 0xff]);
        }
        sprintf(cmd2, "SAVESEG %s", name);

-       cpcmd(cmd1, NULL, 0, NULL);
-       cpcmd(cmd2, NULL, 0, NULL);
+       response = 0;
+       cpcmd(cmd1, NULL, 0, &response);
+       if (response) {
+               PRINT_ERR("segment_save: DEFSEG failed with response code %i\n",
+                         response);
+               goto out;
+       }
+       cpcmd(cmd2, NULL, 0, &response);
+       if (response) {
+               PRINT_ERR("segment_save: SAVESEG failed with response code %i\n",
+                         response);
+               goto out;
+       }
+out:

        spin_unlock(&dcss_lock);
 }
 
        spin_unlock(&dcss_lock);
 }