]> err.no Git - linux-2.6/commit
palm_bk3710: fix IDECLK period calculation
authorSergei Shtylyov <sshtylyov@ru.mvista.com>
Tue, 8 Jul 2008 17:27:22 +0000 (19:27 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 8 Jul 2008 17:27:22 +0000 (19:27 +0200)
commitffab6cf44e9058fe75a33aa86386b22e616a8f6f
treeb31a0bb763c731e380d23abc290f09d620745810
parenta861beb1401d65e3f095fee074c13645ab06490e
palm_bk3710: fix IDECLK period calculation

The driver uses completely bogus rounding formula for calculating period from
the IDECLK frequency which gives one-off period values (e.g. 11 ns with 100 MHz
IDECLK) which in turn can lead to overclocked IDE transfer timings.  Actually,
rounding is just wrong in this case, so use a mere division for a safe result.

While at it, also:

- give 'ide_palm_clk' variable a more suitable name;

- get rid of the useless 'ideclkp' variable;

- drop the LISP stype 'p' postfix from the 'clkp' variable's name. :-)

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: mcherkashin@ru.mvista.com
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/arm/palm_bk3710.c