]> err.no Git - linux-2.6/commit
[PATCH] relayfs: remove warning printk() in relay_switch_subbuf()
authorTom Zanussi <zanussi@us.ibm.com>
Tue, 20 Dec 2005 19:10:22 +0000 (13:10 -0600)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 21 Dec 2005 01:33:22 +0000 (17:33 -0800)
commitfd30fc3256824f03c2ff9317269d66f72f7042ca
tree863a1ba4ddae961e2727343c17d15f64c3f4d463
parentbb44f116a14c4c932f15c79acfafd46bcb43ca9a
[PATCH] relayfs: remove warning printk() in relay_switch_subbuf()

There's currently a diagnostic printk in relay_switch_subbuf() meant as
a warning if you accidentally try to log an event larger than the
sub-buffer size.

The problem is if this happens while logging from somewhere it's not
safe to be doing printks, such as in the scheduler, you can end up with
a deadlock.  This patch removes the warning from relay_switch_subbuf()
and instead prints some diagnostic info when the channel is closed.

Thanks to Mathieu Desnoyers for pointing out the problem and
suggesting a fix.

Signed-off-by: Tom Zanussi <zanussi@us.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/relayfs/relay.c
include/linux/relayfs_fs.h