]> err.no Git - linux-2.6/commit
sata_mv: simplify request/response queue handling
authorMark Lord <liml@rtr.ca>
Sat, 19 Apr 2008 19:06:40 +0000 (15:06 -0400)
committerJeff Garzik <jgarzik@redhat.com>
Fri, 25 Apr 2008 05:25:48 +0000 (01:25 -0400)
commitfcfb1f77cea81f74d865b4d33f2e452ffa1973e8
treeeea4215c354333cbbab55a608d44b7a3aca59dce
parent1cfd19aeb8c8b6291a9d11143b4d8f3dac508ed4
sata_mv: simplify request/response queue handling

Try and simplify handling of the request/response queues.

Maintain the cached copies of queue indexes in a fully-masked state,
rather than having each use of them have to do the masking.

Split off handling of a single crpb response into a separate function,
to reduce complexity in the main mv_process_crpb_entries() routine.

Ignore the rarely-valid error bits from the crpb status field,
as we already handle that information in mv_err_intr().

For now, preserve the rest of the original logic.
A later patch will deal with fixing that separately.

Signed-off-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_mv.c