]> err.no Git - linux-2.6/commit
V4L/DVB (6325): Double-free in cx23885_initdev
authorFlorin Malita <fmalita@gmail.com>
Sat, 13 Oct 2007 14:49:52 +0000 (11:49 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Mon, 22 Oct 2007 14:01:36 +0000 (12:01 -0200)
commitfcf94c89af8acccb14ce37b1c9e8dd6bd32a999d
treea82d52ce361bd08f69db37c009766d0f039e090e
parenta13625c518ca6fd3ff7cb3b66d8023f843a745a3
V4L/DVB (6325): Double-free in cx23885_initdev

Both cx23885_initdev and cx23885_dev_setup free the device in their
error path so a failure in the latter causes a double-free. Since
cx23885_dev_setup is only called from cx23885_initdev, it should be safe
to remove its deallocation and leave the cleanup up to the allocating
function.

Coverity CID 1922.

Signed-off-by: Florin Malita <fmalita@gmail.com>
CC: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/cx23885/cx23885-core.c