]> err.no Git - linux-2.6/commit
[PATCH] fill_tgid: fix task_struct leak and possible oops
authorOleg Nesterov <oleg@tv-sign.ru>
Sat, 28 Oct 2006 17:38:49 +0000 (10:38 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 28 Oct 2006 18:30:54 +0000 (11:30 -0700)
commitfca178c0c6e8d52a1875be36b070f30884ebfae9
tree4bce17647edd3fae6b0ba96407cd1c02037b11d1
parent6e6d9fa6f95e382bb2d5725dda18b9e811418e79
[PATCH] fill_tgid: fix task_struct leak and possible oops

1. fill_tgid() forgets to do put_task_struct(first).

2. release_task(first) can happen after fill_tgid() drops tasklist_lock,
   it is unsafe to dereference first->signal.

This is a temporary fix, imho the locking should be reworked.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/taskstats.c