]> err.no Git - linux-2.6/commit
[netdrvr] natsemi: Fix device removal bug
authorJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 04:01:09 +0000 (00:01 -0400)
committerJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 20:17:59 +0000 (16:17 -0400)
commitf6c4286590e7cb13dd16cb2a6e4dc4a27ce6df1d
tree92826825d123d0f0f52074024045cb43ec721cc5
parent6f686d3d14621b90f3793b705bdf9fa624fd29ca
[netdrvr] natsemi: Fix device removal bug

This episode illustrates how an overused warning can train people to
ignore that warning, which winds up hiding bugs.

The warning

drivers/net/natsemi.c: In function ‘natsemi_remove1’:
drivers/net/natsemi.c:3222: warning: ignoring return value of
‘device_create_file’, declared with attribute warn_unused_result

is oft-ignored, even though at close inspection one notices this occurs
in the /remove/ function, not normally where creation occurs.  A quick
s/create/remove/ and we are fixed, with the warning gone.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/natsemi.c