]> err.no Git - linux-2.6/commit
[PATCH] md: Remove bi_end_io call out from under a spinlock
authorNeilBrown <neilb@suse.de>
Mon, 27 Mar 2006 09:18:17 +0000 (01:18 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 27 Mar 2006 16:45:03 +0000 (08:45 -0800)
commitf6344757a92e5466bf8c23a74ee8f972ff35cb05
treedf390903800e7ea8dcf117d9b5a376e34fb1c741
parentb3b46be38aef5c46a4e144f1bcb8d0cc6bf3ff97
[PATCH] md: Remove bi_end_io call out from under a spinlock

raid5 overloads bi_phys_segments to count the number of blocks that the
request was broken in to so that it knows when the bio is completely handled.

Accessing this must always be done under a spinlock.  In one case we also call
bi_end_io under that spinlock, which probably isn't ideal as bi_end_io could
be expensive (even though it isn't allowed to sleep).

So we reducde the range of the spinlock to just accessing bi_phys_segments.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/md/raid5.c