]> err.no Git - linux-2.6/commit
[PATCH] arm_timer: remove a racy and obsolete PF_EXITING check
authorOleg Nesterov <oleg@tv-sign.ru>
Thu, 15 Jun 2006 16:12:02 +0000 (20:12 +0400)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 17 Jun 2006 17:52:13 +0000 (10:52 -0700)
commitf53ae1dc3429529a58aa538e0a860d713c7079c3
treefa40b981c48269274183da0bebc9db3cad2c2f92
parent30f1e3dd8c72abda343bcf415f7d8894a02b4290
[PATCH] arm_timer: remove a racy and obsolete PF_EXITING check

arm_timer() checks PF_EXITING to prevent BUG_ON(->exit_state)
in run_posix_cpu_timers().

However, for some reason it does so only for CPUCLOCK_PERTHREAD
case (which is imho wrong).

Also, this check is not reliable, PF_EXITING could be set on
another cpu without any locks/barriers just after the check,
so it can't prevent from attaching the timer to the exiting
task.

The previous patch makes this check unneeded.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/posix-cpu-timers.c