]> err.no Git - linux-2.6/commit
[PATCH] knfsd: nfsd4: fix non-terminated string
authorJ. Bruce Fields <bfields@citi.umich.edu>
Fri, 16 Feb 2007 09:28:27 +0000 (01:28 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 16 Feb 2007 16:14:01 +0000 (08:14 -0800)
commitf534a257acfd9dae0a689be64397919907b283ba
treedd8f00c1f2da1bc2f3391bc63378dff0caa5bdd2
parent5575ddf75ca7e61d6f69b96368e03dd88edd4604
[PATCH] knfsd: nfsd4: fix non-terminated string

The server name is expected to be a null-terminated string, so we can't pass
in the raw client identifier.

What's more, the client identifier is just a binary, not necessarily
printable, blob.  Let's just use the ip address instead.  The server name
appears to exist just to help debugging by making some printk's more
informative.

Note that the string is copies into the rpc client structure, so the pointer
to the local variable does not outlive the function call.

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfsd/nfs4callback.c