]> err.no Git - linux-2.6/commit
[PATCH] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module
authorJim Cromie <jim.cromie@gmail.com>
Tue, 27 Jun 2006 09:54:23 +0000 (02:54 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 28 Jun 2006 00:32:43 +0000 (17:32 -0700)
commitf31000e573da052b6b8bcc21faff520b4e2eda7a
tree670d5e6e00da615f70d99a950cfe7b8603edad26
parent58b087cda1e9e46c7061c2282f92bd8e1970bfe7
[PATCH] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module

Use of dev_dbg() and friends is considered good practice.  dev_dbg() needs a
struct device *devp, but nsc_gpio is only a helper module, so it doesnt
have/need its own.  To provide devp to the user-modules (scx200 & pc8736x
_gpio), we add it to the vtable, and set it during init.

Also squeeze nsc_gpio_dump()'s format a little.

[  199.259879]  pc8736x_gpio.0: io09: 0x0044 TS OD PUE  EDGE LO DEBOUNCE

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/nsc_gpio.c
drivers/char/pc8736x_gpio.c
drivers/char/scx200_gpio.c
include/linux/nsc_gpio.h