]> err.no Git - linux-2.6/commit
[PATCH] lib: Fix bug in int_sqrt() for 64 bit longs
authorPeter Williams <pwil3058@bigpond.net.au>
Fri, 3 Feb 2006 11:04:33 +0000 (03:04 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 3 Feb 2006 16:32:08 +0000 (08:32 -0800)
commitf0c00257d63463fa9d692e632fae037d6c0e67b0
tree94ca16b28d70eb96155974909560cced8a3cf383
parent6bf8d889ed453f709dedacabdcf5db47470fdae9
[PATCH] lib: Fix bug in int_sqrt() for 64 bit longs

The implementation of int_sqrt() assumes that longs have 32 bits.  On
systems that have 64 bit longs this will result in gross errors when the
argument to the function is greater than 2^32 - 1 on such systems.  I doubt
whether any such use is currently made of int_sqrt() but the attached patch
fixes the problem anyway.

Signed-off-by: Peter Williams <pwil3058@bigpond.com.au>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
lib/int_sqrt.c