]> err.no Git - linux-2.6/commit
[PATCH] generic_file_buffered_write fixes
authorakpm@osdl.org <akpm@osdl.org>
Sun, 1 May 2005 15:58:35 +0000 (08:58 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Sun, 1 May 2005 15:58:35 +0000 (08:58 -0700)
commitf021e9210185b46e41ec3a0e78ec1621e168eacb
tree5661ced2f5c69f737dcf7673db2ef6e852003d6d
parent69aa3f71580990f39e387d96ed1001d2f5fb04b1
[PATCH] generic_file_buffered_write fixes

Anton Altaparmakov <aia21@cam.ac.uk> points out:

- It calls fault_in_pages_readable() which is completely bogus if @nr_segs >
  1.  It needs to be replaced by a to be written
  "fault_in_pages_readable_iovec()".

- It increments @buf even in the iovec case thus @buf can point to random
  memory really quickly (in the iovec case) and then it calls
  fault_in_pages_readable() on this random memory.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
mm/filemap.c