]> err.no Git - linux-2.6/commit
[PATCH] ITIMER_REAL: fix possible deadlock and race
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 29 Jun 2005 03:44:47 +0000 (20:44 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Wed, 29 Jun 2005 04:20:30 +0000 (21:20 -0700)
commitf01b1b0baa454825ed95c28d2a6a71bbf4510836
tree6a7dda617cdb79933780b841429e67ec7c908d52
parentb36bbb6c3d5244eaf52241ec69f79494137f2db0
[PATCH] ITIMER_REAL: fix possible deadlock and race

As Steven Rostedt pointed out, there are 2 problems with ITIMER_REAL
timers.

1. do_setitimer() does not call del_timer_sync() in case
   when the timer is not pending (it_real_value() returns 0).
   This is wrong, the timer may still be running, and it can
   rearm itself.

2. It calls del_timer_sync() with tsk->sighand->siglock held.
   This is deadlockable, because timer's handler needs this
   lock too.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/itimer.c