]> err.no Git - linux-2.6/commit
V4L/DVB (7060): em28xx: remove has_tuner
authorMauro Carvalho Chehab <mchehab@infradead.org>
Thu, 24 Jan 2008 09:59:20 +0000 (06:59 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Fri, 25 Jan 2008 21:05:12 +0000 (19:05 -0200)
commited086314f4e41eb90a9107c7fb2737230686f668
tree2408565ca609c1c788f7ae7524771dd94d8b80dc
parent72e04f720f23cfa8d4400d832784f3a424379227
V4L/DVB (7060): em28xx: remove has_tuner

has_tuner flag doesn't make much sense, since tuner_type=TUNER_ABSENT
means the same thing.

Having two ways to say that a tuner is not present is
not nice, since it may lead to bad setups. In fact, with the previous
code, if a device were using has_tuner=0, but the user forces a tuner,
with modprobe option tuner=type, the modprobe option won't work.

Also, tveeprom returns TUNER_ABSENT, when tuner is unknown or absent.
So, with the previous logic, in this case, the driver should set
has_tuner=0, or has_tuner=1 otherwise.

Instead of adding several additional tests and setups, better just to
remove .has_tuner.

Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/em28xx/em28xx-cards.c
drivers/media/video/em28xx/em28xx-video.c
drivers/media/video/em28xx/em28xx.h