]> err.no Git - linux-2.6/commit
drivers/video: remove unnecessary pci_dev_put
authorJulia Lawall <julia@diku.dk>
Wed, 6 Feb 2008 09:39:07 +0000 (01:39 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 6 Feb 2008 18:41:15 +0000 (10:41 -0800)
commitea237a6ae953b19d03f29236f095389d7906a0b4
treefe72f63bd5342678b7cd4d59a2308300f34e7dfa
parent5a1c84f1465a90192f55e21ccc67fd396c596374
drivers/video: remove unnecessary pci_dev_put

pci_get_class implicitly does a pci_dev_put on its second argument, so
pci_dev_put is only needed if there is a break out of the loop.

The semantic match detecting this problem is as follows:

// <smpl>
@@
expression dev;
expression E;
@@

* pci_dev_put(dev)
  ... when != dev = E
(
* pci_get_device(...,dev)
|
* pci_get_device_reverse(...,dev)
|
* pci_get_subsys(...,dev)
|
* pci_get_class(...,dev)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/sis/sis_main.c