]> err.no Git - linux-2.6/commit
x86: EFI: fix use of unitialized variable and the cache logic
authorThomas Gleixner <tglx@linutronix.de>
Tue, 12 Feb 2008 18:46:48 +0000 (19:46 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 13 Feb 2008 15:20:35 +0000 (16:20 +0100)
commite85f20518bb928667508c22090c85d458e25a4f7
tree97625e60d0901ec459d2ce245fcaaacf1bd84a4f
parent5d3c8b21e22712137db6bbd246d1bdcbe0a09914
x86: EFI: fix use of unitialized variable and the cache logic

Andi Kleen pointed out that the cache attribute logic is reverse in
efi_enter_virtual_mode(). This problem alone is harmless as we do not
(yet) do cache attribute conflict resolution. (This bug was not present
in the original EFI submission - I introduced it while fixing up rejects.)

While reviewing this code I noticed a second, worse problem: the use of
uninitialized md->virt_addr.

Fix both problems.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/efi.c