]> err.no Git - linux-2.6/commit
[PATCH] Fix filp being passed through raw ioctl handler
authorStephen Tweedie <sct@redhat.com>
Wed, 18 May 2005 15:22:31 +0000 (11:22 -0400)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Wed, 18 May 2005 16:10:02 +0000 (09:10 -0700)
commite72022e13d659bece2fc9cb2dd97afa67047dbca
treec71a8bf39274d7ad105e0618a7f0ff57d1509c17
parentd1ded203adf16b42ca90e9041120ae465ca5c4a6
[PATCH] Fix filp being passed through raw ioctl handler

Don't pass meaningless file handles to block device ioctls.

The recent raw IO ioctl-passthrough fix started passing the raw file
handle into the block device ioctl handler.  That's unlikely to be
useful, as the file handle is actually open on a character-mode raw
device, not a block device, so dereferencing it is not going to yield
useful results to a block device ioctl handler.

Previously we just passed NULL; also not a value that can usefully
be dereferenced, but at least if it does happen, we'll oops instead of
silently pretending that the file is a block device, so NULL is the more
defensive option here.  This patch reverts to that behaviour.

Noticed by Al Viro.

Signed-off-by: Stephen Tweedie <sct@redhat.com>
Acked-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/raw.c