]> err.no Git - linux-2.6/commit
[TCP]: Move sack_ok access to obviously named funcs & cleanup
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Thu, 9 Aug 2007 12:14:46 +0000 (15:14 +0300)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:48:00 +0000 (16:48 -0700)
commite60402d0a909ca2e6e2fbdf9ed004ef0fae36d33
treeb40a00b801cf44f81bebd7dadddb19c0086b145c
parentb9c4595bc4947faa236a849324fe3492e388d949
[TCP]: Move sack_ok access to obviously named funcs & cleanup

Previously code had IsReno/IsFack defined as macros that were
local to tcp_input.c though sack_ok field has user elsewhere too
for the same purpose. This changes them to static inlines as
preferred according the current coding style and unifies the
access to sack_ok across multiple files. Magic bitops of sack_ok
for FACK and DSACK are also abstracted to functions with
appropriate names.

Note:
- One sack_ok = 1 remains but that's self explanary, i.e., it
  enables sack
- Couple of !IsReno cases are changed to tcp_is_sack
- There were no users for IsDSack => I dropped it

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tcp.h
net/ipv4/tcp.c
net/ipv4/tcp_input.c
net/ipv4/tcp_minisocks.c
net/ipv4/tcp_output.c
net/ipv4/tcp_timer.c