]> err.no Git - linux-2.6/commit
KVM: Fix kvm_vcpu_block() task state race
authorMarcelo Tosatti <mtosatti@redhat.com>
Thu, 8 May 2008 22:47:01 +0000 (19:47 -0300)
committerAvi Kivity <avi@qumranet.com>
Sun, 18 May 2008 11:37:12 +0000 (14:37 +0300)
commite5c239cfd5b0ec22751c099dbf4d91f3c504a64f
treed0a63882f0592a4ce23a98478fb9c935213b2e16
parentbd25ed033af52c8c054d43a9cce9c5976266ae74
KVM: Fix kvm_vcpu_block() task state race

There's still a race in kvm_vcpu_block(), if a wake_up_interruptible()
call happens before the task state is set to TASK_INTERRUPTIBLE:

CPU0                            CPU1

kvm_vcpu_block

add_wait_queue

kvm_cpu_has_interrupt = 0
                                set interrupt
                                if (waitqueue_active())
                                        wake_up_interruptible()

kvm_cpu_has_pending_timer
kvm_arch_vcpu_runnable
signal_pending

set_current_state(TASK_INTERRUPTIBLE)
schedule()

Can be fixed by using prepare_to_wait() which sets the task state before
testing for the wait condition.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
virt/kvm/kvm_main.c