]> err.no Git - linux-2.6/commit
sysfs: make sysfs_lookup() return ERR_PTR(-ENOENT) on failed lookup
authorTejun Heo <htejun@gmail.com>
Wed, 16 Jan 2008 03:06:14 +0000 (12:06 +0900)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 16 Jan 2008 17:54:03 +0000 (09:54 -0800)
commite49452c67703d3647467d65275fb893589384fed
tree137d7dea836f16f4efc3c709981dee3d306aa757
parentcbd9c883696da72b2b1f03f909dbacc04bbf8b58
sysfs: make sysfs_lookup() return ERR_PTR(-ENOENT) on failed lookup

sysfs tries to keep dcache a strict subset of sysfs_dirent tree by
shooting down dentries when a node is removed, that is, no negative
dentry for sysfs.  However, the lookup function returned NULL and thus
created negative dentries when the target node didn't exist.

Make sysfs_lookup() return ERR_PTR(-ENOENT) on lookup failure.  This
fixes the NULL dereference bug in sysfs_get_dentry() discovered by
bluetooth rfcomm device moving around.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/sysfs/dir.c