]> err.no Git - linux-2.6/commit
[CRYPTO] blkcipher: Fix handling of kmalloc page straddling
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 9 Sep 2007 07:45:21 +0000 (08:45 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 9 Sep 2007 07:45:21 +0000 (08:45 +0100)
commite4630f9fd8cdc14eb1caa08dafe649eb5ae09985
tree301b4b69b5780ecfa39c9c1f508d57e47da8af29
parentb21010ed6498391c0f359f2a89c907533fe07fec
[CRYPTO] blkcipher: Fix handling of kmalloc page straddling

The function blkcipher_get_spot tries to return a buffer of
the specified length that does not straddle a page.  It has
an off-by-one bug so it may advance a page unnecessarily.

What's worse, one of its callers doesn't provide a buffer
that's sufficiently long for this operation.

This patch fixes both problems.  Thanks to Bob Gilligan for
diagnosing this problem and providing a fix.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/blkcipher.c