]> err.no Git - linux-2.6/commit
[PATCH] libata: replace ap_lock w/ ap->lock in ata_scsi_error()
authorTejun Heo <htejun@gmail.com>
Sun, 2 Jul 2006 18:02:15 +0000 (03:02 +0900)
committerJeff Garzik <jeff@garzik.org>
Thu, 6 Jul 2006 02:05:34 +0000 (22:05 -0400)
commite30349d27e093f32ef517b5416d9dce1998d4676
tree4979a58ac85db319abfc295aa8c4534f65ecc676
parent0662c58b3265f52f708a6d59476bc7862b01f9c0
[PATCH] libata: replace ap_lock w/ ap->lock in ata_scsi_error()

ap_lock was used because &ap->host_set->lock was too long and used a
lot.  Now that &ap->host_set->lock is replaced with ap->lock, there's
no reason to keep ap_lock.

[ed. note: that's not entirely true.  ap_lock is a local variable,
caching the results of a de-ref.  In theory, if the compiler is smart
enough, this patch is cosmetic.  However, since this is not a fast
path (it is the error path), this patch is nonetheless acceptable,
even though it _may_ introduce a performance regression.]

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-eh.c