]> err.no Git - linux-2.6/commit
[PATCH] suspend: fix suspend on single-CPU systems
authorIngo Molnar <mingo@elte.hu>
Sat, 23 Dec 2006 15:55:29 +0000 (16:55 +0100)
committerLinus Torvalds <torvalds@woody.osdl.org>
Sat, 23 Dec 2006 21:59:33 +0000 (13:59 -0800)
commite1d9fd2e3d33b2fec3207171ec8ca6e71d5c81c7
tree541652a20988e413edeba6bd00d150a07d65227f
parentffaa82008f1aad52a6d3979f49d2a76c2928b60f
[PATCH] suspend: fix suspend on single-CPU systems

Clark Williams reported that suspend doesnt work on his laptop on
2.6.20-rc1-rt kernels. The bug was introduced by the following cleanup
commit:

 commit 112cecb2cc0e7341db92281ba04b26c41bb8146d
 Author: Siddha, Suresh B <suresh.b.siddha@intel.com>
 Date:   Wed Dec 6 20:34:31 2006 -0800

    [PATCH] suspend: don't change cpus_allowed for task initiating the suspend

because with this change 'error' is not initialized to 0 anymore, if
there are no other online CPUs. (i.e. if the system is single-CPU).

the fix is the initialize it to 0. The really weird thing is that my
version of gcc does not warn about this non-initialized variable
situation ...

(also fix the kernel printk in the error branch, it was missing a
 newline)

Reported-by: Clark Williams <williams@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/cpu.c