]> err.no Git - linux-2.6/commit
[TCP] FRTO: Clear frto_highmark only after process_frto that uses it
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Wed, 14 Nov 2007 23:55:09 +0000 (15:55 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Nov 2007 23:55:09 +0000 (15:55 -0800)
commite1cd8f78f8cbfa314a095dbf704707217c8ee197
tree3fd93e961b6e0d45813a03bf1c2087f8628ca7b1
parentc67625a1ecd7caf4c0490fc5278d6bb736a5297f
[TCP] FRTO: Clear frto_highmark only after process_frto that uses it

I broke this in commit 3de96471bd7fb76406e975ef6387abe3a0698149:

[TCP]: Wrap-safed reordering detection FRTO check

tcp_process_frto should always see a valid frto_highmark. An invalid
frto_highmark (zero) is very likely what ultimately caused a seqno
compare in tcp_frto_enter_loss to do the wrong leading to the LOST-bit
leak.

Having LOST-bits integry ensured like done after commit
23aeeec365dcf8bc87fae44c533e50d0bb4f23cc:

[TCP] FRTO: Plug potential LOST-bit leak

won't hurt. It may still be useful in some other, possibly legimate,
scenario.

Reported by Chazarain Guillaume <guichaz@yahoo.fr>.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c