]> err.no Git - linux-2.6/commit
[POWERPC] Fix loop logic in irq_alloc_virt()
authorMichael Ellerman <michael@ellerman.id.au>
Wed, 2 Aug 2006 00:48:50 +0000 (10:48 +1000)
committerPaul Mackerras <paulus@samba.org>
Tue, 26 Sep 2006 05:24:34 +0000 (15:24 +1000)
commite12514650b167f48e952d50315fd492d01d42988
tree8ac4f5ca248ef91a1a6550eba64cca2a80a9711b
parent94983cb7881dff760d724759105a6f67935b571d
[POWERPC] Fix loop logic in irq_alloc_virt()

There's a bug in irq_alloc_virt() if it's asked for more than 1 interrupt,
if it can't find a slot it might look past the end of the irq_map.
To be clear: the bug is that the continue affects the inner for loop,
not the outer one, so i becomes j + 1 and then we continue the inner
loop without checking if i is still <= limit.

This fixes it. No one in the kernel actually calls this with count >
1, so it's not critical.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/irq.c