]> err.no Git - linux-2.6/commit
[ALSA] sound/core/memalloc.c: Add missing pci_dev_put
authorJulia Lawall <julia@diku.dk>
Wed, 28 Nov 2007 10:58:56 +0000 (11:58 +0100)
committerJaroslav Kysela <perex@perex.cz>
Thu, 31 Jan 2008 16:29:30 +0000 (17:29 +0100)
commitdf1deb67532ea26f1a033a5f48bf34b30bec8e1d
treecebdf47a832ee63a9deeba4751d556219b627fd3
parent1005f66fd7175916db013dc98ca6b7cec26e5f81
[ALSA] sound/core/memalloc.c: Add missing pci_dev_put

There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.
In this case, the return under the initial if needs a pci_dev_put in the
same way that the return under the subsequent for loop has a pci_dev_put.
This was fixed using the following semantic patch.
// <smpl>
@@
type T;
identifier d;
expression e;
@@
T *d;
...
while ((d = \(pci_get_device\|pci_get_device_reverse\|pci_get_subsys\|pci_get_class\)(..., d)) != NULL)
  {... when != pci_dev_put(d)
       when != e = d
(
    return d;
|
+  pci_dev_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
sound/core/memalloc.c