]> err.no Git - linux-2.6/commit
[DCCP]: Remove unused and redundant validation functions
authorGerrit Renker <gerrit@erg.abdn.ac.uk>
Thu, 13 Dec 2007 14:40:40 +0000 (12:40 -0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 22:57:52 +0000 (14:57 -0800)
commitdd6303df095d18b0c524a76a42f57bcc679b2039
tree7bb19426bb87c895b3b0cdcb3639623481abbcea
parentaf3b867e2f6b72422bc7aacb1f1e26f47a9649bc
[DCCP]: Remove unused and redundant validation functions

This removes two inlines which were both called in a single function only:

 1) dccp_feat_change() is always called with either DCCPO_CHANGE_L or DCCPO_CHANGE_R as argument
    * from dccp_set_socktopt_change() via do_dccp_setsockopt() with DCCP_SOCKOPT_CHANGE_R/L
    * from __dccp_feat_init() via dccp_feat_init() also with DCCP_SOCKOPT_CHANGE_R/L.

    Hence the dccp_feat_is_valid_type() is completely unnecessary and always returns true.

 2) Due to (1), the length test reduces to 'len >= 4', which in turn makes
    dccp_feat_is_valid_length() unnecessary.

Furthermore, the inline function dccp_feat_is_reserved() was unfolded,
since only called in a single place.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/feat.c
net/dccp/feat.h