]> err.no Git - linux-2.6/commit
[PATCH] RTC class: error checks
authorDavid Brownell <david-b@pacbell.net>
Sun, 1 Oct 2006 06:28:16 +0000 (23:28 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 1 Oct 2006 07:39:25 +0000 (00:39 -0700)
commitdb621f174d2c017d960089ea8cbc91c0763f1069
tree68a6ab944fdd30b2e6a7a0fb5a06629a4f4a6af9
parent818a8674b0388d90e33a5d1b13946b40dda7032a
[PATCH] RTC class: error checks

The rtc_is_valid_tm() routine needs to treat some of the fields it checks as
unsigned, to prevent wrongly accepting invalid rtc_time structs; this is the
same approach used elsewhere in the RTC code for such tests.

Conversely, rtc_proc_show() is missing one invalid-day-of-month test that
rtc_is_valid_tm() makes: there is no day zero.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/rtc/rtc-lib.c
drivers/rtc/rtc-proc.c