]> err.no Git - linux-2.6/commit
[TCP]: Fix sorting of SACK blocks.
authorBaruch Even <baruch@ev-en.org>
Thu, 25 Jan 2007 21:35:06 +0000 (13:35 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Jan 2007 21:35:06 +0000 (13:35 -0800)
commitdb3ccdac261e015023cfd922840170f14c9cdc09
treecff3542f6b8b1efa1bbea61ca777d3b34d6e540b
parentdbcb5855d108b7fa20ab42567a5412ce9dcd776a
[TCP]: Fix sorting of SACK blocks.

The sorting of SACK blocks actually munges them rather than sort,
causing the TCP stack to ignore some SACK information and breaking the
assumption of ordered SACK blocks after sorting.

The sort takes the data from a second buffer which isn't moved causing
subsequent data moves to occur from the wrong location. The fix is to
use a temporary buffer as a normal sort does.

Signed-off-By: Baruch Even <baruch@ev-en.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c