]> err.no Git - linux-2.6/commit
V4L/DVB (8876): budget: udelay changed to mdelay
authorThierry MERLE <thierry.merle@free.fr>
Mon, 1 Sep 2008 20:28:57 +0000 (17:28 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 4 Sep 2008 21:26:48 +0000 (18:26 -0300)
commitdb210426d48998ed412f267b28cf6e62ea0496a8
tree4d3f4ee095ab0b0f675dd0fa9a8e52a640279576
parentdb0a2901a32c44510d7d429358d017143a649a70
V4L/DVB (8876): budget: udelay changed to mdelay

budget.ko fails to build on ARM with:

ERROR: "__bad_udelay" [drivers/media/dvb/ttpci/budget.ko] undefined!
make[1]: *** [__modpost] Error 1

__bad_udelay is specifically designed on ARM to fail when udelay is
called in a bad way.  arch/arm/include/asm/delay.h has this to say
about __bad_udelay:

/*
 * This function intentionally does not exist; if you see references to
 * it, it means that you're calling udelay() with an out of range value.
 *
 * With currently imposed limits, this means that we support a max delay
 * of 2000us. Further limits: HZ<=1000 and bogomips<=3355
 */
extern void __bad_udelay(void);

Solution is to replace udelay by a mdelay and udelay with value less than 2000

Acked-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Thierry MERLE <thierry.merle@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/ttpci/budget-patch.c
drivers/media/dvb/ttpci/budget.c