]> err.no Git - linux-2.6/commit
[PATCH] sys_unshare: remove a broken CLONE_SIGHAND code
authorOleg Nesterov <oleg@tv-sign.ru>
Fri, 8 Dec 2006 10:36:09 +0000 (02:36 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:28:38 +0000 (08:28 -0800)
commitdae3c5a0b7052ad7dd9fa78c51ecfab828c5007b
treefea5f0ac63b3b14641593e0c38634829719ff95c
parentae424ae4b5bcd820ad6ee6f0b986c4e14ed4d6cf
[PATCH] sys_unshare: remove a broken CLONE_SIGHAND code

sys_unshare(CLONE_SIGHAND) is broken, the code under 'if (new_sigh)' is
never executed but very wrong. Just remove it to avoid a confusion,
task_lock() has nothing to do with ->sighand changing.

Also, change the comment in unshare_sighand(). Yes, CLONE_THREAD implies
CLONE_SIGHAND, but still it looks confusing. Also, we don't need to check
current->sighand != NULL.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/fork.c