]> err.no Git - linux-2.6/commit
[BLOCK] limit request_fn recursion
authorJens Axboe <axboe@suse.de>
Thu, 11 May 2006 06:20:16 +0000 (08:20 +0200)
committerLinus Torvalds <torvalds@g5.osdl.org>
Thu, 11 May 2006 19:38:59 +0000 (12:38 -0700)
commitdac07ec121de66b6be988b14ae2cd9ce45357b21
tree95359f17d0857fd52f399cef072097523227d032
parentf358166a9405e4f1d8e50d8f415c26d95505b6de
[BLOCK] limit request_fn recursion

Don't recurse back into the driver even if the unplug threshold is met,
when the driver asks for a requeue. This is both silly from a logical
point of view (requeues typically happen due to driver/hardware
shortage), and also dangerous since we could hit an endless request_fn
-> requeue -> unplug -> request_fn loop and crash on stack overrun.

Also limit blk_run_queue() to one level of recursion, similar to how
blk_start_queue() works.

This patch fixed a real problem with SLES10 and lpfc, and it could hit
any SCSI lld that returns non-zero from it's ->queuecommand() handler.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
block/elevator.c
block/ll_rw_blk.c