]> err.no Git - linux-2.6/commit
agp: two-stage page destruction issue
authorJan Beulich <jbeulich@novell.com>
Wed, 18 Jun 2008 08:28:00 +0000 (09:28 +0100)
committerDave Airlie <airlied@redhat.com>
Wed, 18 Jun 2008 23:56:16 +0000 (09:56 +1000)
commitda503fa60b84d5945deb3ab74efdd0bec61df4a1
tree9883d28cabdab419567a2c0689d06c938460eaa1
parentdcd981a77b2b35d169656d4b9cee208096ed7ccf
agp: two-stage page destruction issue

besides it apparently being useful only in 2.6.24 (the changes in 2.6.25
really mean that it could be converted back to a single-stage mechanism),
I'm seeing an issue in Xen Dom0 kernels, which is caused by the calling
of gart_to_virt() in the second stage invocations of the destroy function.
I think that besides this being a real issue with Xen (where
unmap_page_from_agp() is not just a page table attribute change), this
also is invalid from a theoretical perspective: One should not assume that
gart_to_virt() is still valid after unmapping a page. So minimally (keeping
the 2-stage mechanism) a patch like the one below would be needed.

Jan

Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/char/agp/backend.c
drivers/char/agp/generic.c
drivers/char/agp/intel-agp.c