]> err.no Git - linux-2.6/commit
[MIPS] pnx8550: Fix write_config_byte() PCI config space accessor
authorDavy Chan <chandave-linux-mips@wiasia.com>
Fri, 5 Jan 2007 05:56:46 +0000 (13:56 +0800)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 8 Jan 2007 21:41:04 +0000 (21:41 +0000)
commitd98f92371461c5c8cc24e12a212c59b3f437b581
tree690b50b3a8809f55d2b747f8125189d0413d205b
parentf75f369fd783d194cb45632617561ca4d7045849
[MIPS] pnx8550: Fix write_config_byte() PCI config space accessor

There's a serious typo in the function:
  arch/mips/pci/ops-pnx8550.c:write_config_byte()

The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ
instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write
a single byte to the PCI configuration registers useless.

This problem does not exist for write_config_word() nor write_config_dword().

This problem has been there since kernel v2.6.17 and is still there
as of kernel v2.6.19.1.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/pci/ops-pnx8550.c