]> err.no Git - linux-2.6/commit
[PATCH] powerpc: Always panic if lmb_alloc() fails
authorMichael Ellerman <michael@ellerman.id.au>
Wed, 25 Jan 2006 08:31:28 +0000 (21:31 +1300)
committerPaul Mackerras <paulus@samba.org>
Tue, 7 Feb 2006 11:38:34 +0000 (22:38 +1100)
commitd7a5b2ffa1352f0310630934a56aecbdfb617b72
tree5ec2ed1d4e63d4bd2847531115fd263109a16830
parent2fb07d776b3c4473275eb225b6bf2a83755c9bfe
[PATCH] powerpc: Always panic if lmb_alloc() fails

Currently most callers of lmb_alloc() don't check if it worked or not, if it
ever does weird bad things will probably happen. The few callers who do check
just panic or BUG_ON.

So make lmb_alloc() panic internally, to catch bugs at the source. The few
callers who did check the result no longer need to.

The only caller that did anything interesting with the return result was
careful_allocation(). For it we create __lmb_alloc_base() which _doesn't_ panic
automatically, a little messy, but passable.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/prom.c
arch/powerpc/mm/hash_utils_64.c
arch/powerpc/mm/lmb.c
arch/powerpc/mm/mem.c
arch/powerpc/mm/numa.c
arch/powerpc/mm/stab.c
arch/powerpc/sysdev/dart_iommu.c
include/asm-powerpc/lmb.h