]> err.no Git - linux-2.6/commit
revert 'sched: redundant reschedule when set_user_nice() boosts a prio of a task...
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 9 May 2007 03:27:06 +0000 (20:27 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 May 2007 03:41:15 +0000 (20:41 -0700)
commitd5f9f942c601fdebe57f7805e4b4fbad9c28ada8
tree6a212ceabd844fbaf517a13a9f885be5ab1c59b5
parentda4e8ca376a1b3dca470eba14dcec321a6a27b8b
revert 'sched: redundant reschedule when set_user_nice() boosts a prio of a task from the "expired" array'

Revert commit bd53f96ca54a21c07e7a0ae1886fa623d370b85f.

Con says:

This is no good, sorry. The one I saw originally was with the staircase
deadline cpu scheduler in situ and was different.

  #define TASK_PREEMPTS_CURR(p, rq) \
     ((p)->prio < (rq)->curr->prio)
     (((p)->prio < (rq)->curr->prio) && ((p)->array == (rq)->active))

This will fail to wake up a runqueue for a task that has been migrated to the
expired array of a runqueue which is otherwise idle which can happen with smp
balancing,

Cc: Dmitry Adamushko <dmitry.adamushko@gmail.com>
Cc: Con Kolivas <kernel@kolivas.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sched.c