]> err.no Git - linux-2.6/commit
[PATCH] taskstats: fix sk_buff leak
authorOleg Nesterov <oleg@tv-sign.ru>
Sun, 29 Oct 2006 13:45:58 +0000 (16:45 +0300)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 29 Oct 2006 20:07:37 +0000 (12:07 -0800)
commitd46a3d0d07ba539aea5b0e1ad30e568f0cb03576
tree2db10dd06537a27bbdd16080c56db33f884812bb
parent5211e6e6c671f0d4b1e1a1023384d20227d8ee65
[PATCH] taskstats: fix sk_buff leak

'return genlmsg_cancel()' in taskstats_user_cmd/taskstats_exit_send
potentially leaks a skb.  Unless we pass 'rep_skb' to the netlink layer
we own sk_buff.  This means we should always do kfree_skb() on failure.

[ Thomas acked and pointed out missing return value in original version ]

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Thomas Graf <tgraf@suug.ch>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/taskstats.c