]> err.no Git - linux-2.6/commit
Fix failure exits in asus-laptop
authorAl Viro <viro@ftp.linux.org.uk>
Tue, 24 Jul 2007 01:43:54 +0000 (18:43 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 24 Jul 2007 19:24:59 +0000 (12:24 -0700)
commitd316ee5787153765980ca0f55ee864ec883979ab
tree2fb761e5b33f63e80bc018cd19027ec88626e035
parentc51aea80a9fbb423b49d432e89e515257bb2b983
Fix failure exits in asus-laptop

Fallout from f8a7c6fe14f556ca8eeddce258cb21392d0c3a2f.  However, looking
at it shows that checks done in ASUS_LED_UNREGISTER() can't trigger
at all (we never get to asus_led_exit() if registration fails) and
if that registration fails, we actually leak stuff.  IOW, it's worse
than just replacing class_dev with dev in there - the tests themselves
had been papering over the lousy cleanup logics.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Karol Kozimor <sziwan@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/misc/asus-laptop.c