]> err.no Git - linux-2.6/commit
[PATCH] reiserfs: reset errval after initializing bitmap cache
authorJeff Mahoney <jeffm@suse.com>
Fri, 3 Nov 2006 06:07:20 +0000 (22:07 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 3 Nov 2006 20:27:58 +0000 (12:27 -0800)
commitd2c89a4284ea4ecfba77c6f2d7d6f96d52e801e5
treef51cc68a56a52cad0fd91a33c6a86821bf9abf31
parentd3e5a938e7ed718f6d191e8b6b176fcfeb88a294
[PATCH] reiserfs: reset errval after initializing bitmap cache

Callers after reiserfs_init_bitmap_cache() expect errval to contain -EINVAL
until much later.  If a condition fails before errval is reset later,
reiserfs_fill_super() will mistakenly return 0, causing an Oops in
do_add_mount().  This patch resets errval to -EINVAL after the call.

I view this as a temporary fix and real error codes should be used
throughout reiserfs_fill_super().

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/reiserfs/super.c