]> err.no Git - linux-2.6/commit
[NETFILTER] NAT: Fix module refcount dropping too far
authorHarald Welte <laforge@netfilter.org>
Thu, 3 Nov 2005 19:17:51 +0000 (20:17 +0100)
committerArnaldo Carvalho de Melo <acme@mandriva.com>
Sat, 5 Nov 2005 03:23:34 +0000 (01:23 -0200)
commitd2a7bb7141a1fac7b11523538b2d2407e928baeb
tree67fdabbfbdc0b53154a4f6aa1a33c383db02bfb2
parentd811552eda2476215d69d485e437d2dcae1ab0b4
[NETFILTER] NAT: Fix module refcount dropping too far

The unknown protocol is used as a fallback when a protocol isn't known.
Hence we cannot handle it failing, so don't set ".me".  It's OK, since we
only grab a reference from within the same module (iptable_nat.ko), so we
never take the module refcount from 0 to 1.

Also, remove the "protocol is NULL" test: it's never NULL.

Signed-off-by: Rusty Rusty <rusty@rustcorp.com.au>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
net/ipv4/netfilter/ip_nat_core.c
net/ipv4/netfilter/ip_nat_proto_unknown.c