]> err.no Git - linux-2.6/commit
[NET] netconsole: Remove bogus check
authorSatyam Sharma <satyam@infradead.org>
Fri, 10 Aug 2007 22:28:10 +0000 (15:28 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:48:02 +0000 (16:48 -0700)
commitd133ccbdc30c7f86459519cec1126d6473762b10
tree37f41671ddba891149a7aec6c3ab349c81a9a7c1
parentd39badf05b52f99169b22ce324fd31c8b44a0473
[NET] netconsole: Remove bogus check

Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.

The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
set by netpoll_setup(), which is called by init_netconsole() before
register_console(), so write_msg() cannot be triggered unless netpoll_setup()
successfully set np.dev.  Also np.dev cannot go away from under us, because
netpoll_setup() grabs us reference on it.  So let's remove the bogus check.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netconsole.c