]> err.no Git - linux-2.6/commit
md: Fix check for overlapping devices.
authorAndre Noll <maan@systemlinux.org>
Mon, 21 Jul 2008 04:42:07 +0000 (14:42 +1000)
committerNeilBrown <neilb@suse.de>
Mon, 21 Jul 2008 04:42:07 +0000 (14:42 +1000)
commitd07bd3bcc456228b56a790897162a634691fed9b
treecabb0feee45a7b3383fff4202adc35793c8bdbb1
parentd7027458d68b2f1752a28016dcf2ffd0a7e8f567
md: Fix check for overlapping devices.

The checks in overlaps() expect all parameters either in block-based
or sector-based quantities. However, its single caller passes two
rdev->data_offset arguments as well as two rdev->size arguments, the
former being sector counts while the latter are measured in 1K blocks.

This could cause rdev_size_store() to accept an invalid size from user
space. Fix it by passing only sector-based quantities to overlaps().

Signed-off-by: Andre Noll <maan@systemlinux.org>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/md.c