]> err.no Git - linux-2.6/commit
[PATCH] rivafb/nvidiafb: race between register_framebuffer and *_bl_init
authorGuido Guenther <agx@sigxcpu.org>
Sun, 30 Jul 2006 10:04:21 +0000 (03:04 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 31 Jul 2006 20:28:45 +0000 (13:28 -0700)
commitce38cac48209d270d07fd6d1a8e94446b37abcd5
treec7840212a8dbc2002734e20ed2e3b0e8f63c857c
parentb1367d2a2817e6199092b43fe01c1eed3374c4e4
[PATCH] rivafb/nvidiafb: race between register_framebuffer and *_bl_init

Since we now use the generic backlight infrastructure, I think we need to
call rivafb_bl_init before calling register_framebuffer since otherwise
rivafb_bl_init might race with the framebuffer layer already opening the
device and setting up the video mode.  In this case we might end up with a
not yet fully intialized backlight (info->bl_dev still NULL) when calling
riva_bl_set_power via rivafb_set_par/rivafb_load_video_mode and the kernel
dies without any further notice during boot.

This fixes booting current git on a PB 6,1.  In this case radeonfb/atyfb
would be affected too - I can fix that too but don't have any hardware to
test this on.

Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/nvidia/nvidia.c
drivers/video/riva/fbdev.c