]> err.no Git - linux-2.6/commit
[PATCH] kmsg_write: don't return printk return value
authorGuillaume Chazarain <guichaz@yahoo.fr>
Sun, 8 Jan 2006 09:02:43 +0000 (01:02 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 9 Jan 2006 04:13:53 +0000 (20:13 -0800)
commitcd140a5c1f456f50897af4a2e9a23d228a5fe719
tree24170cf30ce2c5d3129c9b535942c4c52231a042
parent025510cd20f4c35c3958bea133d96c9bd7c6ef9e
[PATCH] kmsg_write: don't return printk return value

kmsg_write returns with printk, so some programs may be confused by a
successful write() with a return value different than the buffer length.

# /bin/echo something > /dev/kmsg
/bin/echo: write error: Inappropriate ioctl for device

The drawbacks is that the printk return value can no more be quickly
checked from userspace.

Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/mem.c