]> err.no Git - linux-2.6/commit
[POWERPC] Demacrofy arch/powerpc/platforms/maple/pci.c
authorNathan Lynch <ntl@pobox.com>
Thu, 21 Sep 2006 19:31:13 +0000 (14:31 -0500)
committerPaul Mackerras <paulus@samba.org>
Fri, 22 Sep 2006 05:19:58 +0000 (15:19 +1000)
commitcc9881ce371dc7ff3ef5404feda59566fabaf521
tree3326f263f308f9c3c4bc6cb2737e3c1377fade2a
parentd608df5c7da6ee968aa2ad43c596d5f8d4022299
[POWERPC] Demacrofy arch/powerpc/platforms/maple/pci.c

Noticed that the U3_*CFA macros have some typos:

#define U3_HT_CFA0(devfn, off) \
((((unsigned long)devfn) << 8) | offset)

(refers to offset rather than off)

#define U3_AGP_CFA0(devfn, off) \
((1 << (unsigned long)PCI_SLOT(dev_fn)) \
| (((unsigned long)PCI_FUNC(dev_fn)) << 8) \

(refers to dev_fn rather than devfn)

Things happen to work, but there doesn't seem to be any reason these
shouldn't be functions.  Overall behavior should be unchanged.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/maple/pci.c