]> err.no Git - linux-2.6/commit
ACPI: thinkpad-acpi: do not use named sysfs groups
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Wed, 30 May 2007 23:50:14 +0000 (20:50 -0300)
committerLen Brown <len.brown@intel.com>
Thu, 31 May 2007 16:53:00 +0000 (12:53 -0400)
commitcc4c24e115ca7bc2e4ec74d70bcb8fda1d1a8df8
tree9da120a598b8f540c8b72050f7d252c700316c9f
parent68ccfaa8222f2a26f0689fad9e8c0c3f4c19f599
ACPI: thinkpad-acpi: do not use named sysfs groups

The initial version of the thinkpad-acpi sysfs interface (not yet released
in any stable mainline kernel) made liberal use of named sysfs groups, in
order to get the attributes more organized.

This proved to be a really bad design decision.  Maybe if attribute groups
were as flexible as a real directory, and if binary attributes were not
second-class citizens, the idea of subdirs and named groups would not have
been so bad.

This patch makes all the thinkpad-acpi sysfs groups anonymous (thus
removing the subdirs), adds the former group names as a prefix (so that
hotkey/enable becomes hotkey_enable for example), and updates the
documentation.

These changes will make the thinkpad-acpi sysfs ABI a lot easier to
maintain.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Len Brown <len.brown@intel.com>
Documentation/thinkpad-acpi.txt
drivers/misc/thinkpad_acpi.c
drivers/misc/thinkpad_acpi.h