]> err.no Git - linux-2.6/commit
packet: fix error handling
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 25 Apr 2007 20:01:21 +0000 (13:01 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 25 Apr 2007 20:50:55 +0000 (13:50 -0700)
commitcbc31a475a7f7748bd0a4e536533868e7cff8645
treeaef103b0ba0076988b7d5f8c967351443cb785b6
parent5044eed48886b105a123333fe7ca97c6bd496120
packet: fix error handling

The packet driver is assuming (reasonably) that the (undocumented)
request.errors is an errno.  But it is in fact some mysterious bitfield.  When
things go wrong we return weird positive numbers to the VFS as pointers and it
goes oops.

Thanks to William Heimbigner for reporting and diagnosis.

(It doesn't oops, but this driver still doesn't work for William)

Cc: William Heimbigner <icxcnika@mar.tar.cc>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/pktcdvd.c