]> err.no Git - linux-2.6/commit
[PATCH] Signedness issue in drivers/net/3c515.c
authorEric Sesterhenn <snakebyte@gmx.de>
Sat, 19 Aug 2006 17:37:57 +0000 (19:37 +0200)
committerJeff Garzik <jeff@garzik.org>
Thu, 24 Aug 2006 04:37:04 +0000 (00:37 -0400)
commitcb958186ed543d1a4f074ceb1c783fe8b0908437
tree852a5b70ff626b7b9dbf1c1e6da5a65b55cb40c7
parenta76b044af147135b5fb7570aba35d4908f143cc9
[PATCH] Signedness issue in drivers/net/3c515.c

while playing with gcc 4.1 -Wextra warnings, I came across this one:

drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true

Since i is unsigned the >= 0 check in the for loop is always true,
so we might spin there forever unless the if condition triggers.
Since i is only used in this loop, this patch changes it to
an integer.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/3c515.c