]> err.no Git - linux-2.6/commit
Input: ads7846 - handle IRQs that were latched during disabled IRQs
authorImre Deak <imre.deak@nokia.com>
Wed, 12 Apr 2006 03:44:05 +0000 (23:44 -0400)
committerDmitry Torokhov <dtor_core@ameritech.net>
Wed, 12 Apr 2006 03:44:05 +0000 (23:44 -0400)
commitc9e617a563ad646239270fa2222cdb06966cf1fa
tree7598f9bc96914b4540b1d682eb2e9876343c272a
parent7de90a8cb9c51145d7f60d8db17ce0fa07d1b281
Input: ads7846 - handle IRQs that were latched during disabled IRQs

The pen down IRQ will toggle during each X,Y,Z measurement cycle.
Even though the IRQ is disabled it will be latched and delivered
when after enable_irq. Thus in the IRQ handler we must avoid
starting a new measurement cycle when such an "unwanted" IRQ happens.
Add a get_pendown_state platform function, which will probably
determine this by reading the current GPIO level of the pen IRQ pin.

Move the IRQ reenabling from the SPI RX function to the timer. After
the last power down message the pen IRQ pin is still active for a
while and get_pendown_state would report incorrectly a pen down state.

When suspending we should check the ts->pending flag instead of
ts->pendown, since the timer can be pending regardless of ts->pendown.
Also if ts->pending is set we can be sure that the timer is running,
so no need to rearm it. Similarly if ts->pending is not set we can
be sure that the IRQ is enabled (and the timer is not).

Signed-off-by: Imre Deak <imre.deak@nokia.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/touchscreen/ads7846.c
include/linux/spi/ads7846.h